Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent filter pushdown in distributed planner #1806

Merged
merged 2 commits into from
Jun 21, 2023
Merged

fix: prevent filter pushdown in distributed planner #1806

merged 2 commits into from
Jun 21, 2023

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Prevent pushing down filter plan in distributed planner since Like expr is not supported in substrait now

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@waynexia
fix: prevent filter pushdown in distributed planner
315e48b 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
etolbakov
etolbakov approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@etolbakov etolbakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia mentioned this pull request Jun 20, 2023
Closed
evenyag
evenyag approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia
fix metadata
03555f1 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@killme2008 killme2008 merged commit b1ccc7e into GreptimeTeam:develop Jun 21, 2023
@waynexia waynexia deleted the disable-filter-pushdown branch June 21, 2023 08:27
@killme2008 killme2008 mentioned this pull request Jun 21, 2023
Closed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@waynexia @paomian
fix: prevent filter pushdown in distributed planner (GreptimeTeam#1806)
4e86c6d 
* fix: prevent filter pushdown in distributed planner

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* fix metadata

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

---------

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@NiwakaDev NiwakaDev mentioned this pull request Dec 9, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenyag evenyag evenyag approved these changes

@etolbakov etolbakov etolbakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waynexia @etolbakov @evenyag @killme2008