Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deal with node epoch #1795

Merged
merged 5 commits into from
Jun 20, 2023

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Deal with node epoch.
If the node is redeployed and the member_id, peer are reused,
metasrv must clear the old information to ensure that the scheduling will not be wrong.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@fengjiachun fengjiachun marked this pull request as draft June 20, 2023 04:13
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #1795 (7f9a27f) into develop (2dd86b6) will decrease coverage by 0.39%.
The diff coverage is 91.58%.

❗ Current head 7f9a27f differs from pull request most recent head f5e56e7. Consider uploading reports for the commit f5e56e7 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1795      +/-   ##
===========================================
- Coverage    86.62%   86.23%   -0.39%     
===========================================
  Files          582      583       +1     
  Lines        94696    95058     +362     
===========================================
- Hits         82029    81974      -55     
- Misses       12667    13084     +417     

@fengjiachun fengjiachun marked this pull request as ready for review June 20, 2023 06:25
src/meta-srv/src/handler/persist_stats_handler.rs Outdated Show resolved Hide resolved
src/meta-srv/src/service/store/ext.rs Outdated Show resolved Hide resolved
fengjiachun and others added 3 commits June 20, 2023 14:49
Co-authored-by: dennis zhuang <killme2008@gmail.com>
Co-authored-by: dennis zhuang <killme2008@gmail.com>
@fengjiachun fengjiachun force-pushed the feat/meta/node-epoch branch from 7f9a27f to f5e56e7 Compare June 20, 2023 06:56
@fengjiachun fengjiachun enabled auto-merge (squash) June 20, 2023 07:00
@fengjiachun fengjiachun merged commit 4fdee5e into GreptimeTeam:develop Jun 20, 2023
@fengjiachun fengjiachun deleted the feat/meta/node-epoch branch June 20, 2023 07:07
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: deal with node epoch

* feat: dn send node_epoch

* Update src/meta-srv/src/handler/persist_stats_handler.rs

Co-authored-by: dennis zhuang <killme2008@gmail.com>

* Update src/meta-srv/src/service/store/ext.rs

Co-authored-by: dennis zhuang <killme2008@gmail.com>

* chore: by cr

---------

Co-authored-by: dennis zhuang <killme2008@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants