Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support restart sqlness in distributed mode #1443

Merged
merged 4 commits into from
Apr 24, 2023

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Apr 23, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • move the alter_table case to common dir
  • correct the subcommand when restarting distributed mode
  • refactor the start and check connection function

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Closes #1442

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #1443 (391d381) into develop (9f442de) will decrease coverage by 0.57%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1443      +/-   ##
===========================================
- Coverage    85.87%   85.31%   -0.57%     
===========================================
  Files          542      543       +1     
  Lines        81111    81278     +167     
===========================================
- Hits         69654    69339     -315     
- Misses       11457    11939     +482     

tests/runner/src/env.rs Outdated Show resolved Hide resolved
tests/runner/src/env.rs Outdated Show resolved Hide resolved
waynexia and others added 2 commits April 24, 2023 10:49
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Co-authored-by: LFC <bayinamine@gmail.com>
@waynexia waynexia requested a review from killme2008 April 24, 2023 02:50
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 merged commit b9db2cf into GreptimeTeam:develop Apr 24, 2023
@waynexia waynexia deleted the sqlness-restart-dist branch April 24, 2023 11:37
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* fix: support restart sqlness in distributed mode

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* move alter_table case to common dir

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* is_standalone flag

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* Update tests/runner/src/env.rs

Co-authored-by: LFC <bayinamine@gmail.com>

---------

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Co-authored-by: LFC <bayinamine@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support sqlness restart in distributed mode
3 participants