-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support restart sqlness in distributed mode #1443
Merged
killme2008
merged 4 commits into
GreptimeTeam:develop
from
waynexia:sqlness-restart-dist
Apr 24, 2023
Merged
fix: support restart sqlness in distributed mode #1443
killme2008
merged 4 commits into
GreptimeTeam:develop
from
waynexia:sqlness-restart-dist
Apr 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #1443 +/- ##
===========================================
- Coverage 85.87% 85.31% -0.57%
===========================================
Files 542 543 +1
Lines 81111 81278 +167
===========================================
- Hits 69654 69339 -315
- Misses 11457 11939 +482 |
killme2008
reviewed
Apr 23, 2023
MichaelScofield
approved these changes
Apr 24, 2023
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Co-authored-by: LFC <bayinamine@gmail.com>
killme2008
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2 tasks
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* fix: support restart sqlness in distributed mode Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * move alter_table case to common dir Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * is_standalone flag Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * Update tests/runner/src/env.rs Co-authored-by: LFC <bayinamine@gmail.com> --------- Signed-off-by: Ruihang Xia <waynestxia@gmail.com> Co-authored-by: LFC <bayinamine@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
alter_table
case to common dirChecklist
Refer to a related PR or issue link (optional)
Closes #1442