Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: release the standalone binaries with pyo3 and install python utils in images #1194

Merged
merged 4 commits into from
Mar 17, 2023

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Mar 17, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Release the standalone binaries with pyo3 support for multiple platforms;
  2. Install python3/python3-dev/python3-pip/pyarrow(We release the images with pyo3 function);

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@zyy17 zyy17 changed the title ci: release the standalone binaries with pyo3 and install python utils in containers ci: release the standalone binaries with pyo3 and install python utils in images Mar 17, 2023
@zyy17 zyy17 requested review from discord9, evenyag and waynexia March 17, 2023 03:06
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docker/ci/Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😵

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #1194 (55368b0) into develop (62e2a60) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1194      +/-   ##
===========================================
- Coverage    85.21%   84.98%   -0.24%     
===========================================
  Files          485      485              
  Lines        71973    72017      +44     
===========================================
- Hits         61334    61203     -131     
- Misses       10639    10814     +175     

@zyy17 zyy17 merged commit 09491d6 into GreptimeTeam:develop Mar 17, 2023
@zyy17 zyy17 deleted the ci/pyo3-binary branch March 17, 2023 07:42
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
…s in images (GreptimeTeam#1194)

* ci: install python3 and python3-dev in CI Dockerfile

* ci: release the standalone binaries with pyo3 support for multiple platforms

* refactor: install pip and pyarrow

* refactor: specify the python version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants