-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove the SQL execution interfaces in Datanode #1135
Merged
MichaelScofield
merged 2 commits into
GreptimeTeam:develop
from
MichaelScofield:refactor/datanode-no-sql
Mar 13, 2023
Merged
refactor: remove the SQL execution interfaces in Datanode #1135
MichaelScofield
merged 2 commits into
GreptimeTeam:develop
from
MichaelScofield:refactor/datanode-no-sql
Mar 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelScofield
requested review from
killme2008,
sunng87,
fengjiachun,
v0y4g3r,
evenyag and
waynexia
March 7, 2023 12:12
Codecov Report
@@ Coverage Diff @@
## develop #1135 +/- ##
===========================================
+ Coverage 85.02% 85.15% +0.13%
===========================================
Files 482 484 +2
Lines 71386 71152 -234
===========================================
- Hits 60697 60593 -104
+ Misses 10689 10559 -130 |
MichaelScofield
force-pushed
the
refactor/datanode-no-sql
branch
from
March 8, 2023 02:13
bcc3dd2
to
81c0e2b
Compare
6 tasks
MichaelScofield
force-pushed
the
refactor/datanode-no-sql
branch
from
March 8, 2023 09:00
81c0e2b
to
4812a4e
Compare
evenyag
reviewed
Mar 9, 2023
MichaelScofield
force-pushed
the
refactor/datanode-no-sql
branch
from
March 9, 2023 07:02
4812a4e
to
cb0e020
Compare
Resolved, PTAL @evenyag |
evenyag
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sunng87
reviewed
Mar 9, 2023
MichaelScofield
force-pushed
the
refactor/datanode-no-sql
branch
from
March 10, 2023 03:40
cb0e020
to
0b44788
Compare
@MichaelScofield There are some conflicts. |
MichaelScofield
force-pushed
the
refactor/datanode-no-sql
branch
from
March 13, 2023 10:22
0b44788
to
9ecd791
Compare
resolved, PTAL @killme2008 @sunng87 |
sunng87
approved these changes
Mar 13, 2023
LGTM. Good job! |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…am#1135) * refactor: remove the SQL execution interfaces in Datanode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Motivation: #1010
This PR:
StatementHandler
. When more statements are executed in the form of logical plan, this StatementHandler will be removed eventually.So the SQL execution path is like this:
Frontend Instance still impl the SqlQueryHandler, which is called by servers. Inside the impl:
The plan is to gradually move all statement execution to logical plan execution. Finally unified to query_engine's execution of logical plan.
The difference between standalone and distributed execution of logical plan should be revealed in different implementation of QueryEngine, which will be in the following PRs.
LogicalPlanner
, making codes more clear.Checklist
Refer to a related PR or issue link (optional)
#1010