Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add Integrated Test for Coprocessor& fix minor bugs #1122

Merged
merged 19 commits into from
Mar 6, 2023
Merged

test: add Integrated Test for Coprocessor& fix minor bugs #1122

merged 19 commits into from
Mar 6, 2023

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Mar 3, 2023 •
edited by killme2008
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Added Integrated Test for Coprocessor, fix some minor bugs.

  • Integrated tests for both RsPy and CPython backend
  • fix CoprStream 's schema not set to it's output types' problem
  • fix UDF have useless truncate of it's output's bug
  • cache Runtime used in block_on_async
  • added lit function for DataFrame API for both backend
  • impl rfloordiv&floordiv&filter for pyo3 backend&tested
  • added to_pyarrow and from_to_pyarrow for vector to convert to pyarrow.array

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

@discord9 discord9 force-pushed the py_async_refactor branch from ac2e8b2 to f16779e Compare March 3, 2023 13:57
@discord9 discord9 marked this pull request as ready for review March 3, 2023 13:59
killme2008
killme2008 reviewed Mar 3, 2023
View reviewed changes
src/common/function/src/scalars/udf.rs Outdated Show resolved Hide resolved
src/script/src/python/engine.rs Outdated Show resolved Hide resolved
src/script/src/python/engine.rs Outdated Show resolved Hide resolved
src/script/src/python/engine.rs Outdated Show resolved Hide resolved
src/script/src/python/engine.rs Outdated Show resolved Hide resolved
src/script/src/python/ffi_types/pair_tests/sample_testcases.rs Outdated Show resolved Hide resolved
src/script/src/python/ffi_types/pair_tests/sample_testcases.rs Outdated Show resolved Hide resolved
src/script/src/python/pyo3/dataframe_impl.rs Show resolved Hide resolved
tests-integration/tests/http.rs Outdated Show resolved Hide resolved
src/script/src/python/pyo3/builtins.rs Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 4, 2023 •
edited
Loading

Codecov Report

Merging #1122 (378a50e) into develop (bd065ea) will increase coverage by 0.13%.
The diff coverage is 84.04%.

@@             Coverage Diff             @@
##           develop    #1122      +/-   ##
===========================================
+ Coverage    85.02%   85.16%   +0.13%     
===========================================
  Files          474      474              
  Lines        69073    69847     +774     
===========================================
+ Hits         58732    59485     +753     
- Misses       10341    10362      +21

killme2008
killme2008 reviewed Mar 5, 2023
View reviewed changes
src/script/src/python/engine.rs Outdated Show resolved Hide resolved
src/script/src/python/engine.rs Outdated Show resolved Hide resolved
src/script/src/python/engine.rs Outdated Show resolved Hide resolved
src/script/src/python/engine.rs Outdated Show resolved Hide resolved
src/script/src/python/engine.rs Outdated Show resolved Hide resolved
src/script/src/python/pyo3/vector_impl.rs Outdated Show resolved Hide resolved
src/script/src/python/pyo3/dataframe_impl.rs Show resolved Hide resolved
src/script/src/python/ffi_types/pair_tests/sample_testcases.rs Outdated Show resolved Hide resolved
src/script/src/python/pyo3/builtins.rs Show resolved Hide resolved
src/script/src/python/pyo3/dataframe_impl.rs Show resolved Hide resolved
@killme2008 killme2008 requested a review from waynexia March 6, 2023 08:55
killme2008
killme2008 approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

waynexia
waynexia approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've skimmed on this and it looks good to me

src/script/src/python/pyo3/vector_impl.rs Show resolved Hide resolved
src/common/function/src/scalars/udf.rs Outdated Show resolved Hide resolved
@killme2008
Copy link
Contributor

I merged this PR. Please create another PR to refactor all OtherSnafu stuff.

@killme2008 killme2008 merged commit 379f581 into develop Mar 6, 2023
@killme2008 killme2008 deleted the py_async_refactor branch March 6, 2023 11:21
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@discord9 @paomian
test: add Integrated Test for Coprocessor& fix minor bugs (GreptimeTe…
7c93155 
…am#1122)

* feat: cache `Runtime`

* fix: coprstream schema not set

* test: integrated tests for Coprocessor

* fix: UDF fixed

* style: remove unused import

* chore: remove more unused import

* feat: `filter`, (r)floordiv for Vector

* chore: CR advices

* feat: auto convert to `lit`

* chore: fix typo

* feat: from&to `pyarrow.array`

* feat: allow `pyarrow.array` as args to builtins

* chore: cargo fmt

* test: CI add `pyarrow`

* test: install Python&PyArrow in CI

* test: not cache depend for now

* chore: CR advices

* test: fix name

* style: rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@killme2008 killme2008 killme2008 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@discord9 @killme2008 @waynexia