feat: specify prom server start addr #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanbohan
force-pushed
the
start-promql-cmd
branch
from
f3c01c0 to
795054d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1111 +/- ##
===========================================
+ Coverage 85.09% 85.16% +0.07%
===========================================
Files 473 474 +1
Lines 68605 68897 +292
===========================================
+ Hits 58380 58679 +299
+ Misses 10225 10218 -7 |
|
|
yuanbohan
changed the title
yuanbohan
force-pushed
the
start-promql-cmd
branch
from
e6ee740 to
aeb012a
Compare
yuanbohan
force-pushed
the
start-promql-cmd
branch
from
aeb012a to
50c261e
Compare
Shall we create an issue for this? I'm not sure whether we already have an issue tracking this. |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: specify promql server start addr * refactor: rename promql to prom in Prometheus API server scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
start prometheus API server with specified addr, so the
/queryand/query_rangecan be accessible outside of container by running the standalone mode:cargo run -- standalone start --prom-addr=0.0.0.0:4004