chore: Rename MetaClientOpts to MetaClientOptions #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenyag
changed the title
evenyag
changed the title
evenyag
added
breaking-change
Codecov Report
@@ Coverage Diff @@
## develop #1075 +/- ##
===========================================
- Coverage 85.75% 85.64% -0.11%
===========================================
Files 451 451
Lines 65980 65998 +18
===========================================
- Hits 56583 56527 -56
- Misses 9397 9471 +74
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
BREAKING CHANGE: Change the meta_client_opts in the config file to meta_client_options
evenyag
force-pushed
the
fix/options-to-toml
branch
from
22032e5 to
a7e92f6
Compare
MichaelScofield
approved these changes
Feb 24, 2023
waynexia
changed the title
|
😥 |
waynexia
changed the title
waynexia
approved these changes
Feb 24, 2023
2 tasks
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* fix: Serialize FrontendOptions to toml * fix: Serialize DatanodeOptions to toml * fix: Serialize StandaloneOptions to toml See https://users.rust-lang.org/t/why-toml-to-string-get-error-valueaftertable/85903/2 * chore!: Rename MetaClientOpts to MetaClientOptions BREAKING CHANGE: Change the meta_client_opts in the config file to meta_client_options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR
toml::to_string()to serialize them. See https://users.rust-lang.org/t/why-toml-to-string-get-error-valueaftertable/85903/2BREAKING CHANGE: This PR renames
meta_client_optssection in the toml file tometa_client_optionsChecklist
Refer to a related PR or issue link (optional)