chore: fix some typo and add deriv to plan in promql (#1438)

GreptimeTeam · Apr 23, 2023 · 9f442de · 9f442de
1 parent 5d77ed0
commit 9f442de
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/promql/src/functions/deriv.rs b/src/promql/src/functions/deriv.rs
@@ -29,8 +29,8 @@ use datatypes::arrow::datatypes::DataType;
 use crate::functions::{extract_array, linear_regression};
 use crate::range_array::RangeArray;
 
-#[range_fn(name = "Deriv", ret = "Float64Array", display_name = "prom_drive")]
-pub fn drive(times: &TimestampMillisecondArray, values: &Float64Array) -> Option<f64> {
+#[range_fn(name = "Deriv", ret = "Float64Array", display_name = "prom_deriv")]
+pub fn deriv(times: &TimestampMillisecondArray, values: &Float64Array) -> Option<f64> {
     if values.len() < 2 {
         None
     } else {

diff --git a/src/promql/src/planner.rs b/src/promql/src/planner.rs
@@ -51,9 +51,9 @@ use crate::extension_plan::{
     EmptyMetric, InstantManipulate, Millisecond, RangeManipulate, SeriesDivide, SeriesNormalize,
 };
 use crate::functions::{
-    AbsentOverTime, AvgOverTime, Changes, CountOverTime, Delta, HoltWinters, IDelta, Increase,
-    LastOverTime, MaxOverTime, MinOverTime, PredictLinear, PresentOverTime, QuantileOverTime, Rate,
-    Resets, StddevOverTime, StdvarOverTime, SumOverTime,
+    AbsentOverTime, AvgOverTime, Changes, CountOverTime, Delta, Deriv, HoltWinters, IDelta,
+    Increase, LastOverTime, MaxOverTime, MinOverTime, PredictLinear, PresentOverTime,
+    QuantileOverTime, Rate, Resets, StddevOverTime, StdvarOverTime, SumOverTime,
 };
 
 const LEFT_PLAN_JOIN_ALIAS: &str = "lhs";
@@ -776,6 +776,7 @@ impl PromPlanner {
             "irate" => ScalarFunc::Udf(IDelta::<true>::scalar_udf()),
             "resets" => ScalarFunc::Udf(Resets::scalar_udf()),
             "changes" => ScalarFunc::Udf(Changes::scalar_udf()),
+            "deriv" => ScalarFunc::Udf(Deriv::scalar_udf()),
             "avg_over_time" => ScalarFunc::Udf(AvgOverTime::scalar_udf()),
             "min_over_time" => ScalarFunc::Udf(MinOverTime::scalar_udf()),
             "max_over_time" => ScalarFunc::Udf(MaxOverTime::scalar_udf()),