Add isHidden to RecipeMaps to hide the default RecipeMapCategory #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serenibyss
approved these changes
Jun 3, 2021
LAGIdiot
added
status: accepted
subsystem: recipes
type: feature
TechLord22
referenced
this pull request
in GregTechCEu/GregTech
Jul 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This particular PR solves a problem with RecipeMaps, where the auto-generated RecipeMapCategory could not be stopped from being registered. For RecipeMaps with particularly notable features that required them to gain a new wrapper and category, this issue prevented them from stopping the registration of the default.
How solved:
To fix this, I added a boolean, isHidden, which when true, would prevent the default category from being registered. I made sure to add this through a new constructor in RecipeMap, which is linked to by the old one, to prevent compatibility issues.
Outcome:
Allows for default RecipeMapCategories to be hidden.
Additional info:
You may have noticed that I created a very similar PR a few hours ago. However, since my knowledge of Git is quite poor, that repository was riddled with duplicate commits, and as such, I was forced to delete it.
Possible compatibility issue:
Since the normal RecipeMap constructor is still used in this PR, and works as intended for the end user, there shouldn't be any compatibillity issues here.