Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2 #437

Merged
merged 43 commits into from
Jan 16, 2024
Merged

Release 1.2 #437

merged 43 commits into from
Jan 16, 2024

Conversation

in4margaret and others added 30 commits March 4, 2023 16:34
Fix missing FromQuery params
Fix integration tests not using JSON datasource mocker
I, Margaret <in4margaret@gmail.com>, hereby add my Signed-off-by to this commit: f881406
I, Margaret <in4margaret@gmail.com>, hereby add my Signed-off-by to this commit: f343cab

Signed-off-by: Margaret <in4margaret@gmail.com>
Signed-off-by: Yasumasa Suenaga <yasuenag@gmail.com>
* cleaning workflows

Signed-off-by: Dan Benitah <bdanuw@gmail.com>

* pull request should on trigger for pull request event - removing on push for PRs

Signed-off-by: Dan Benitah <bdanuw@gmail.com>

* syntax

Signed-off-by: Dan Benitah <bdanuw@gmail.com>

* syntax

Signed-off-by: Dan Benitah <bdanuw@gmail.com>

* moving markdown linting and disabling 2.a-deploy

Signed-off-by: Dan Benitah <bdanuw@gmail.com>

* adding some jobs dependencies so packaging does not run if code does not build etc...

Signed-off-by: Dan Benitah <bdanuw@gmail.com>

* moving code analysis into the build step and clean up

Signed-off-by: Dan Benitah <bdanuw@gmail.com>

---------

Signed-off-by: Dan Benitah <bdanuw@gmail.com>
Co-authored-by: danuw <danuw@volto.io>
* Skip deploy workflows in forked repos

Signed-off-by: Yasumasa Suenaga <suenaga@oss.nttdata.com>

* Add vars

Signed-off-by: Yasumasa Suenaga <suenaga@oss.nttdata.com>

---------

Signed-off-by: Yasumasa Suenaga <suenaga@oss.nttdata.com>
Signed-off-by: Roman Lutz <romanlutz13@gmail.com>
Signed-off-by: Yasumasa Suenaga <suenaga@oss.nttdata.com>
Signed-off-by: Yasumasa Suenaga <suenaga@oss.nttdata.com>
Signed-off-by: Yasumasa Suenaga <suenaga@oss.nttdata.com>
Signed-off-by: Yasumasa Suenaga <suenaga@oss.nttdata.com>
Signed-off-by: Yasumasa Suenaga <suenaga@oss.nttdata.com>
Signed-off-by: Yasumasa Suenaga <suenaga@oss.nttdata.com>
Signed-off-by: Yasumasa Suenaga <suenaga@oss.nttdata.com>
Issue : 

I have tested a ElectricityMaps forecast scenario CLI: 
"emissions-forecasts -l westeurope -v"
will return server error 500.

Analysis:

public async Task<EmissionsForecast> GetCurrentCarbonIntensityForecastAsync(Location location) is causing the EM server to return 500. Reason is that the "." in geolocation.Latitude will be passed as "," 

Fix:

The following changes are fixing this bug.

Signed-off-by: Christian Binder <43334159+xcbinder@users.noreply.github.com>
Signed-off-by: Yasumasa Suenaga <suenaga@oss.nttdata.com>
fixing 3 broken links in overview.md

Signed-off-by: nttDamien <125525959+nttDamien@users.noreply.github.com>
Integration tests coverage for WebAPI and CLI
Signed-off-by: Roman Lutz <romanlutz13@gmail.com>
Discussed about this in:
- #392 (comment)
- #381 (comment)

Signed-off-by: Yasumasa Suenaga <suenaga@oss.nttdata.com>
Signed-off-by: Yasumasa Suenaga <suenaga@oss.nttdata.com>
I, Yasumasa Suenaga <suenaga@oss.nttdata.com>, hereby add my Signed-off-by to this commit: 4e0b3a1

Signed-off-by: Yasumasa Suenaga <suenaga@oss.nttdata.com>
Signed-off-by: Szymon Duchniewicz <szduchniewicz@gmail.com>
Fix: verify-azure-function-with-packages #383
…receives request for forecast

Signed-off-by: Yasumasa Suenaga <suenaga@oss.nttdata.com>
EMFree data source should regard specified time range
YaSuenag and others added 11 commits October 4, 2023 11:18
Signed-off-by: Yasumasa Suenaga <suenaga@oss.nttdata.com>
Signed-off-by: Yasumasa Suenaga <suenaga@oss.nttdata.com>
Signed-off-by: Yasumasa Suenaga <suenaga@oss.nttdata.com>
Signed-off-by: Sophie Trinder <144015600+Sophietn@users.noreply.github.com>
Signed-off-by: Sophie Trinder <144015600+Sophietn@users.noreply.github.com>
Add Helm chart and workflow
Updating CONTRIBUTING.md
Signed-off-by: Dan Benitah <bdanuw@gmail.com>
Signed-off-by: Dan Benitah <bdanuw@gmail.com>
Signed-off-by: Dan Benitah <bdanuw@gmail.com>
@danuw danuw added the v1.2 label Dec 19, 2023
@danuw danuw added this to the Release 1.2 milestone Dec 19, 2023
@danuw danuw requested a review from vaughanknight as a code owner December 19, 2023 08:37
@danuw danuw self-assigned this Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #437 (d8247a2) into main (ad44005) will increase coverage by 0.46%.
Report is 4 commits behind head on main.
The diff coverage is 15.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
+ Coverage   74.21%   74.67%   +0.46%     
==========================================
  Files          77       77              
  Lines        2637     2646       +9     
  Branches      266      268       +2     
==========================================
+ Hits         1957     1976      +19     
+ Misses        598      589       -9     
+ Partials       82       81       -1     
Files Coverage Δ
...re.WebApi/src/Controllers/CarbonAwareController.cs 93.82% <ø> (ø)
...arbonAware.WebApi/src/Models/CarbonIntensityDTO.cs 100.00% <100.00%> (ø)
...s.ElectricityMaps/src/ElectricityMapsDataSource.cs 65.04% <50.00%> (+0.97%) ⬆️
...icityMapsFree/src/ElectricityMapsFreeDataSource.cs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Updating release date

Signed-off-by: Dan Benitah <bdanuw@gmail.com>
@danuw danuw mentioned this pull request Jan 11, 2024
6 tasks
@danuw
Copy link
Collaborator Author

danuw commented Jan 11, 2024

As previously agreed with @YaSuenag his DCO was overridden again.

@vaughanknight @Willmish could you do us the honours as I created this PR.

Will merge end of day otherwise as all checks are passed now. - Thanks

cc @Sophietn

@vaughanknight vaughanknight merged commit f8c2b96 into main Jan 16, 2024
18 checks passed
@Sophietn
Copy link
Contributor

Well done team!

@Willmish Willmish mentioned this pull request Feb 12, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

9 participants