Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove opensearch observability plugin from datanode #21045

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Remove opensearch observability plugin from datanode #21045

merged 2 commits into from
Nov 26, 2024

Conversation

todvora
Copy link
Contributor

@todvora todvora commented Nov 25, 2024 •
edited
Loading

This plugin is not used anyhow. Let's reduce distribution size, speed up startup of the opensearch and avoid possible problems during plugin init.

/nocl

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@todvora todvora requested a review from moesterheld November 25, 2024 09:42
@todvora todvora marked this pull request as ready for review November 25, 2024 09:42
moesterheld
moesterheld approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. i don't see any need for it, too. thank you

@moesterheld moesterheld merged commit ab51ce8 into master Nov 26, 2024
6 checks passed
@moesterheld moesterheld deleted the datanode/delete-opensearch-observability-plugin branch November 26, 2024 16:08
garybot2 pushed a commit that referenced this pull request Dec 12, 2024
@todvora @github-actions
Remove opensearch observability plugin from datanode (#21045)
9ef4d5b 
(cherry picked from commit ab51ce8)
@graylog-internal-actions-access graylog-internal-actions-access bot mentioned this pull request Dec 12, 2024
Merged
9 tasks
moesterheld pushed a commit that referenced this pull request Dec 17, 2024
@graylog-internal-actions-access @todvora
Remove opensearch observability plugin from datanode (#21045) (#21170)
83bd4bb 
(cherry picked from commit ab51ce8)

Co-authored-by: Tomas Dvorak <tomas.dvorak@graylog.com>
@Elwell
Copy link

Elwell commented Jan 10, 2025

For info, an upgrade of our datanodes from 6.1.4 to 6.1.5 today broke because of this - They'd left an empty stub directory in the plugins directory and startup threw the following error:

[2025-01-09T21:27:35,857][INFO ][o.o.n.Node ] [datanode-2.novalocal] version[2.15.0], pid[9454], build[tar/61dbcd0795c9bfe9b81e5762175414bc38bbcadf/2024-06-20T03:26:49.193630411Z], OS[Linux/5. 14.0-503.19.1.el9_5.x86_64/amd64], JVM[Eclipse Adoptium/OpenJDK 64-Bit Server VM/21.0.3/21.0.3+9-LTS] [2025-01-09T21:27:35,966][ERROR][o.o.b.Bootstrap ] [datanode-2.novalocal] Exception java.lang.IllegalStateException: Could not load plugin descriptor for plugin directory [opensearch-observability]

It was obvious when doing an ls -l of /usr/share/graylog-datanode/dist/opensearch-2.15.0-linux-x64/plugins/ as there was an empty 'opensearch-observability' directory. - a swift rmdir and I was able to restart graylog-datanode service sucessfully

@todvora todvora mentioned this pull request Jan 10, 2025
Closed
@bernd bernd mentioned this pull request Jan 10, 2025
Closed
@todvora
Copy link
Contributor Author

todvora commented Jan 10, 2025

@Elwell Thanks again for your bug report. It was a problem in RPM package and it's already fixed and new version of the package is now available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moesterheld moesterheld moesterheld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@todvora @Elwell @moesterheld