fix: DDL batch errors halfway were not propagated #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A DDL batch that executed at least one statement successfully and then failed for a later statement would be reported as successful. This was caused by an invalid extraction of the returned update counts from the SpannerBatchUpdateException. The exception contains a full list of update counts for all statements in the batch. The value is 1 for a statement that was (successfully) executed and 0 for all other statements. The extraction of the update counts assumed that the list would only contain an entry for the statements that were actually executed. Fixes #443
Codecov Report
@@ Coverage Diff @@
## postgresql-dialect #444 +/- ##
========================================================
+ Coverage 87.29% 87.32% +0.03%
- Complexity 2020 2022 +2
========================================================
Files 122 122
Lines 6651 6651
Branches 957 957
========================================================
+ Hits 5806 5808 +2
+ Misses 595 594 -1
+ Partials 250 249 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A DDL batch that executed at least one statement successfully and then failed for a later statement would be reported as successful. This was caused by an invalid extraction of the returned update counts from the SpannerBatchUpdateException. The exception contains a full list of update counts for all statements in the batch. The value is 1 for a statement that was (successfully) executed and 0 for all other statements. The extraction of the update counts assumed that the list would only contain an entry for the statements that were actually executed.
Fixes #443