Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify Python version in Node.js services #616

Merged
merged 4 commits into from
Nov 12, 2021
Merged

Specify Python version in Node.js services #616

merged 4 commits into from
Nov 12, 2021

Conversation

julianwagle
Copy link
Contributor

@julianwagle julianwagle commented Nov 9, 2021 •
edited
Loading

Fixes # .

Change summary:

Was getting the following error when building locally:

Step 2/13 : FROM base as builder
 ---> f534e2bb4a44
Step 3/13 : RUN apk add --update --no-cache     python     make     g++
 ---> Running in 7f14a56197d5
fetch https://dl-cdn.alpinelinux.org/alpine/v3.14/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.14/community/x86_64/APKINDEX.tar.gz
ERROR: unable to select packages:
  python (no such package):
    required by: world[python]
Building [adservice]...
Canceled build for adservice
Building [paymentservice]...
Canceled build for paymentservice
Building [recommendationservice]...
Canceled build for recommendationservice
Building [shippingservice]...
Canceled build for shippingservice
Building [productcatalogservice]...
Canceled build for productcatalogservice
Building [checkoutservice]...
Canceled build for checkoutservice
Building [emailservice]...
Canceled build for emailservice
Building [frontend]...
Canceled build for frontend
unable to stream build output: The command '/bin/sh -c apk add --update --no-cache     python     make     g++' returned a non-zero code: 1. Please fix the Dockerfile and try again..

Found the solution here: nodejs/docker-node#1605, then updated the Dockerfiles for Currencyservice and Paymentservice (the two NodeJS based services) accordingly.

Remaining issues / concerns:
May want to update from Node:12 in the future. As a first time contributor I'm not going to try pushing that but it may be smart going forward.

@julianwagle julianwagle requested a review from a team as a code owner November 9, 2021 14:53
@google-cla
Copy link

google-cla bot commented Nov 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 9, 2021
@julianwagle
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 9, 2021
@NimJay NimJay mentioned this pull request Nov 11, 2021
Closed
@NimJay NimJay self-requested a review November 11, 2021 17:07
NimJay
NimJay approved these changes Nov 12, 2021
View reviewed changes
Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull-request is equivalent to #621 which I've tested.
Approved!

Thanks again, @julianwagle, for doing this for us! 👏

@NimJay NimJay changed the title Updated Node-based Dockerfiles Specify Python version in Node.js services Nov 12, 2021
@NimJay NimJay merged commit fd8924b into GoogleCloudPlatform:master Nov 12, 2021
@NimJay NimJay mentioned this pull request Nov 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NimJay NimJay NimJay approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianwagle @NimJay