Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folder migrate #4421

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Folder migrate #4421

merged 2 commits into from
Jan 22, 2021

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented Jan 21, 2021 •
edited by trodge
Loading

Fixes: hashicorp/terraform-provider-google#8198

This will not build until containers are updated. Updating containers will break existing/new PRs until this is merged

Plan for merging:

  1. Pause merging
  2. Update containers to use new subfolder
  3. Confirm this PR builds successfully
  4. Merge this PR

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@google-cla google-cla bot added the cla: yes label Jan 21, 2021
@slevenick slevenick requested a review from rileykarson January 21, 2021 22:45
@rileykarson
Copy link
Member

Generally looks good- I think the links in the README need updating, but everything else is 👍

Do you want a +1 now, or when we've got the build stuff in place? I'm assuming it's best to fix the dataproc stuff after the freeze.

@slevenick slevenick force-pushed the folder-migrate branch 2 times, most recently from 3804ab5 to afe8935 Compare January 21, 2021 23:10
@slevenick
Copy link
Contributor Author

/gcbrun

1 similar comment
@slevenick
Copy link
Contributor Author

/gcbrun

@slevenick
Move files to subfolder
7add56e 
Update containers, gitignore

Remove gitmodules, move yamllint

Revert changes to ci
@slevenick
Add README note
6838998
@slevenick
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=168473"

@slevenick slevenick merged commit 1d293f7 into GoogleCloudPlatform:master Jan 22, 2021
@slevenick slevenick mentioned this pull request Jan 22, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Magic Modules version 1 (MMv1) into a subfolder within the magic-modules repo
3 participants
@slevenick @rileykarson @modular-magician