Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

license_test: update to allow Google LLC. #647

Merged
merged 1 commit into from
Oct 12, 2018
Merged

license_test: update to allow Google LLC. #647

merged 1 commit into from
Oct 12, 2018

Conversation

tbpg
Copy link
Contributor

@tbpg tbpg commented Oct 12, 2018

This switches the test to use regexp and check the year is 4 digits. There does not seem to be an impact on test speed.

@tbpg tbpg requested a review from broady October 12, 2018 13:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 12, 2018
@broady
Copy link
Contributor

broady commented Oct 12, 2018

So odd that mailgun only failed on 1.11...

@tbpg
Copy link
Contributor Author

tbpg commented Oct 12, 2018 •
edited
Loading

go vet is only run with Go 1.11. So, I guess if there are no tests, go test doesn't try to compile the package?

@tbpg tbpg merged commit f0460ec into master Oct 12, 2018
@tbpg tbpg deleted the license branch October 12, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broady broady broady approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbpg @broady @googlebot