Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: chirp 2 notebook #1210

Merged
merged 10 commits into from
Oct 4, 2024
Merged

feat: chirp 2 notebook #1210

merged 10 commits into from
Oct 4, 2024

Conversation

inardini
Copy link
Contributor

@inardini inardini commented Oct 4, 2024

Description

This tutorial shows how to use Chirp 2, the latest generation of Google's multilingual ASR-specific models.

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • You are listed as the author in your notebook or README file.
    • Your account is listed in CODEOWNERS for the file(s).
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
  • Ensure the tests and linter pass (Run nox -s format from the repository root to format).
  • Appropriate docs were updated (if necessary)

@inardini inardini requested a review from a team as a code owner October 4, 2024 00:36
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@inardini inardini changed the title chirp 2 notebook feat: chirp 2 notebook Oct 4, 2024
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
holtskinner
holtskinner reviewed Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@holtskinner holtskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First part of review comments.

Thanks for making this!

audio/speech/getting-started/get_started_with_chirp_sdk.ipynb Outdated Show resolved Hide resolved
audio/speech/getting-started/get_started_with_chirp_2_sdk.ipynb Outdated Show resolved Hide resolved
audio/speech/getting-started/get_started_with_chirp_2_sdk.ipynb Outdated Show resolved Hide resolved
audio/speech/getting-started/get_started_with_chirp_2_sdk.ipynb Outdated Show resolved Hide resolved
audio/speech/getting-started/get_started_with_chirp_2_sdk.ipynb Outdated Show resolved Hide resolved
audio/speech/getting-started/get_started_with_chirp_2_sdk.ipynb Outdated Show resolved Hide resolved
audio/speech/getting-started/get_started_with_chirp_2_sdk.ipynb Outdated Show resolved Hide resolved
audio/speech/getting-started/get_started_with_chirp_2_sdk.ipynb Outdated Show resolved Hide resolved
audio/speech/getting-started/get_started_with_chirp_2_sdk.ipynb Outdated Show resolved Hide resolved
audio/speech/getting-started/get_started_with_chirp_2_sdk.ipynb Outdated Show resolved Hide resolved
holtskinner
holtskinner approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@holtskinner holtskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments on things that could be improved, but LGTM overall

audio/speech/getting-started/get_started_with_chirp_2_sdk.ipynb Outdated Show resolved Hide resolved
audio/speech/getting-started/get_started_with_chirp_2_sdk.ipynb Outdated Show resolved Hide resolved
audio/speech/getting-started/get_started_with_chirp_2_sdk.ipynb Show resolved Hide resolved
audio/speech/getting-started/get_started_with_chirp_2_sdk.ipynb Show resolved Hide resolved
audio/speech/getting-started/get_started_with_chirp_2_sdk.ipynb Show resolved Hide resolved
audio/speech/getting-started/get_started_with_chirp_2_sdk.ipynb Show resolved Hide resolved
audio/speech/getting-started/get_started_with_chirp_2_sdk.ipynb Outdated Show resolved Hide resolved
audio/speech/getting-started/get_started_with_chirp_2_sdk.ipynb Outdated Show resolved Hide resolved
audio/speech/getting-started/get_started_with_chirp_2_sdk.ipynb Show resolved Hide resolved
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@inardini inardini merged commit d7e0cc6 into GoogleCloudPlatform:main Oct 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holtskinner holtskinner holtskinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inardini @holtskinner