Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: mark build folder as not generated for GitHub UI #14192

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

connorjclark
Copy link
Collaborator

Thanks @brasic!

ref https://news.ycombinator.com/item?id=31996020

(this may not work right away, pending an internal GH change)

@connorjclark connorjclark requested a review from a team as a code owner July 6, 2022 19:09
@connorjclark connorjclark requested review from adamraine and removed request for a team July 6, 2022 19:09
@brasic
Copy link

brasic commented Jul 6, 2022

No problem! I'll comment here when the PR ships (much of the company is currently on vacation so it will be next week at the earliest)

@connorjclark connorjclark merged commit 2efb2d3 into master Jul 7, 2022
@connorjclark connorjclark deleted the fix-build-gh branch July 7, 2022 18:46
@brasic
Copy link

brasic commented Jul 14, 2022

@connorjclark I've enabled this feature for GoogleChrome/lighthouse and it appears to be working. LMK if you see any issues. It should be fully rolled out to all repos in a week or so. Thanks again for the feedback!

Screen Shot 2022-07-13 at 8 17 13 PM

@connorjclark
Copy link
Collaborator Author

Works great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants