Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle security issue with cookies on Safari #2711

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

gregberge
Copy link
Contributor

Fix GITBOOK-OPEN-1WQZ

Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: e646e72

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gregberge gregberge force-pushed the security-issue-cookie-safari branch from 40955bb to 45ab021 Compare January 9, 2025 13:21
Copy link
Contributor

github-actions bot commented Jan 9, 2025

GitBook Preview
Latest commit: https://bbdfe55e.gitbook-open.pages.dev
PR: https://pr2711.gitbook-open.pages.dev

Copy link

argos-ci bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 11 changed Jan 9, 2025, 4:03 PM

@gregberge gregberge force-pushed the security-issue-cookie-safari branch from 45ab021 to a13a943 Compare January 9, 2025 14:36
@gregberge gregberge requested a review from clairechabas January 9, 2025 15:42
Copy link
Contributor

@emmerich emmerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any other places we're using js-cookie directly? Let's move them all to the lib

@gregberge
Copy link
Contributor Author

are there any other places we're using js-cookie directly? Let's move them all to the lib

No there is no normally!

Fix GITBOOK-OPEN-1WQZ
Fix GITBOOK-OPEN-1WPY
@gregberge gregberge force-pushed the security-issue-cookie-safari branch from 849eeeb to e646e72 Compare January 9, 2025 15:55
@gregberge gregberge merged commit 32aa1f9 into main Jan 9, 2025
9 checks passed
@gregberge gregberge deleted the security-issue-cookie-safari branch January 9, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants