Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option notify_interval won't be inherited #6

Closed
luckyfreddy opened this issue Sep 13, 2023 · 6 comments · Fixed by #7
Closed

Option notify_interval won't be inherited #6

luckyfreddy opened this issue Sep 13, 2023 · 6 comments · Fixed by #7
Assignees
@GioF71
Labels
enhancement New feature or request

Comments

@luckyfreddy
Copy link

Hello. Thanks for the great implementation of minidlna in docker(-compose). Unfortunately the environment-option
" - MINIDLNA_NOTIFY_INTERVAL=20"
in the docker-compose.yml-file won't be implemented in the "/app/conf/minidlna.conf" in the container. The option will be ignored. Is there an hidden option to set for implementing it?

The option "notify_interval" set the time to broadcast and the value of 20 is the only way to getting recognized by my TV after powering on.

Great thanks for checking.
@GioF71
Copy link
Owner

GioF71 commented Sep 13, 2023

Hello, there is simply no support in this project for that variable, it's not in the Dockerfile and also not in the documentation.
But it looks like it is a very good idea to add it, I will check how to set it correctly!

@GioF71 GioF71 added the enhancement New feature or request label Sep 13, 2023
@GioF71 GioF71 self-assigned this Sep 13, 2023
GioF71 added a commit that referenced this issue Sep 13, 2023
@GioF71
Option notify_interval won't be inherited #6
f86ce1e
@GioF71 GioF71 linked a pull request Sep 13, 2023 that will close this issue
Option notify_interval won't be inherited #6 #7
Merged
@GioF71 GioF71 closed this as completed in #7 Sep 13, 2023
GioF71 added a commit that referenced this issue Sep 13, 2023
@GioF71
Option notify_interval won't be inherited #6 (#7)
928c213
@GioF71
Copy link
Owner

GioF71 commented Sep 13, 2023

Hello @luckyfreddy, please check the latest image and the updated README.md file.
Let me know if this work as expected.

@luckyfreddy
Copy link
Author

Now tested and it worked. I really appreciate this. Thanks.

@GioF71
Copy link
Owner

GioF71 commented Sep 13, 2023

Thank you. Consider starring the repo if this is not an issue for you. Cheers!

@luckyfreddy
Copy link
Author

Sure. Hope I have done it right cause i'm new at github.

@GioF71
Copy link
Owner

GioF71 commented Sep 13, 2023

Yes you did it right, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GioF71 GioF71

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Option notify_interval won't be inherited #6 GioF71/minidlna-docker
2 participants
@GioF71 @luckyfreddy