Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped test failing because of cURL error #345

Merged
merged 2 commits into from
Oct 17, 2018

Conversation

christophherr
Copy link
Member

Fixed WPCS errors to pass Sniffer.
see: #344

@christophherr christophherr requested a review from iCaspar October 17, 2018 14:05
@iCaspar
Copy link
Contributor

iCaspar commented Oct 17, 2018

@christophherr I'm not sure what this test actually proves, other than that wp_remote_get() sometimes fails. As such, if we have or can write a unit test that covers the internals of the method, such that if it fails we can prove that it does so gracefully, I'd be in favor of just removing this (and probably the one for http as well).

@christophherr
Copy link
Member Author

Thank you, @iCaspar.
It's one of the tests that confirms what we know from the unit tests but with actual content...

@christophherr christophherr merged commit 5f94284 into Getbeans:development Oct 17, 2018
@christophherr christophherr deleted the fix/skip-test branch October 17, 2018 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants