new readmes and environment #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elidana
reviewed
Dec 18, 2024
elidana
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Hi @rumachan , this looks very good thanks!
I made a couple of suggestions (feel free to take them onboard or not), but before this is merged I think the volcano/README.md need to be changed.
Right now is a copy of README.md, so can we please update it so it describe the general content of the Volcano section of the tutorials? Thanks!
rumachan
force-pushed
the
readmes_enviroment
branch
from
fb854c5 to
52cbb1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping up the volcano tutorial stuff in the repo.