Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fits edits #45

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fits edits #45

merged 1 commit into from
Apr 25, 2024

Conversation

rumachan
Copy link
Contributor

Changes to notebook and README

@rumachan rumachan requested a review from Thomas-Benson April 12, 2024 02:23
Copy link
Contributor

@Thomas-Benson Thomas-Benson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor typos that could be fixed

FITS/FITS_data_access.ipynb Show resolved Hide resolved
FITS/FITS_data_access.ipynb Show resolved Hide resolved
FITS/FITS_data_access.ipynb Show resolved Hide resolved
@rumachan
Copy link
Contributor Author

Those changes made. My typing is shocking! Please re-review.

@rumachan rumachan requested a review from Thomas-Benson April 22, 2024 04:47
Copy link
Contributor

@Thomas-Benson Thomas-Benson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of those typos were there before your edits, they're just minors things I caught looking through it. I probably should have caught them myself when I did all the other ones. Either way the version of this tutorial on the J drive looks fine now, so you should be good to upload it to github.

@rumachan rumachan merged commit 7330c8d into GeoNet:main Apr 25, 2024
@rumachan rumachan deleted the fits branch April 25, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants