Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Canvas Resolution Overhaul #172

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Full Canvas Resolution Overhaul #172

merged 5 commits into from
Oct 24, 2023

Conversation

GenoImel
Copy link
Owner

@GenoImel GenoImel commented Oct 22, 2023

Changes:

  • All canvas systems now use a reference resolution of 3840x2160.
  • All canvas systems now use a reference pixels per unit of 100.
  • All canvases match width or height at a ratio of 0.5.
  • Multiple prefabs were destroyed and recreated during this process.
  • The entire GameManager prefab was unpacked completely, before replacing the old one.

Notes:

Please test thoroughly... it is highly likely something may have broken.

With these settings, our canvas systems should (in theory) play nice with most displays at any display resolution and aspect ratio.

For More Info See:

closes #171

@GenoImel GenoImel self-assigned this Oct 22, 2023
@GenoImel GenoImel added the enhancement New feature or request label Oct 22, 2023
yokozach
yokozach previously approved these changes Oct 22, 2023
Copy link
Collaborator

@jckrebs jckrebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I load the BattleScene, I get these error messages in the console:

Screenshot 2023-10-23 131354

Everything else seems to work ok.

@GenoImel GenoImel requested review from jckrebs and yokozach October 23, 2023 22:00
@GenoImel GenoImel merged commit 090e941 into main Oct 24, 2023
@GenoImel GenoImel deleted the feature/171-canvas-overhaul branch October 24, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canvas System Overhaul
4 participants