Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated load_ocean_ridge_points function (deprecated since v0.6.0) #2308

Merged
merged 5 commits into from
Jan 14, 2023
Merged

Remove the deprecated load_ocean_ridge_points function (deprecated since v0.6.0) #2308

merged 5 commits into from
Jan 14, 2023

Conversation

willschlitzer
Copy link
Contributor

This replaces load_ocean_ridge_points with _load_ocean_ridge_points.

It also changes the argument sep=r"\s+" to delim_whitespace=True.

Addresses: #2302

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the deprecation Deprecating a feature label Jan 4, 2023
@willschlitzer willschlitzer added this to the 0.9.0 milestone Jan 4, 2023
@willschlitzer willschlitzer self-assigned this Jan 4, 2023
@willschlitzer willschlitzer mentioned this pull request Jan 4, 2023
Closed
7 tasks
@yvonnefroehlich yvonnefroehlich mentioned this pull request Jan 5, 2023
Merged
7 tasks
willschlitzer and others added 2 commits January 6, 2023 07:05
@willschlitzer @yvonnefroehlich
Apply suggestions from code review
15478bf 
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@willschlitzer
Merge branch 'main' into deprecate-load_ocean_ridge_points
523a787
seisman
seisman approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Jan 6, 2023
seisman
seisman reviewed Jan 7, 2023
View reviewed changes
pygmt/datasets/samples.py Outdated Show resolved Hide resolved
pygmt/datasets/samples.py Outdated Show resolved Hide resolved
@seisman seisman merged commit 203c30b into main Jan 14, 2023
@seisman seisman deleted the deprecate-load_ocean_ridge_points branch January 14, 2023 04:15
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvonnefroehlich yvonnefroehlich yvonnefroehlich left review comments

@michaelgrund michaelgrund michaelgrund approved these changes

@seisman seisman seisman approved these changes

Assignees

@willschlitzer willschlitzer

Labels
deprecation Deprecating a feature
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@willschlitzer @seisman @michaelgrund @yvonnefroehlich