feat: Added address screen #648
Conversation
daviroo
force-pushed
the
add-set-address-modal
branch
from
404c490 to
1b82248
Compare
| titleStyle: TextProps | ||
| }) => { | ||
| const [isDropdownOpen, setIsDropdownOpen] = React.useState(false) | ||
| const open = useSharedValue(false) |
There was a problem hiding this comment.
Can the state for isDropdownOpen and open be consolidated or do we need both?
There was a problem hiding this comment.
Not sure actually. I'm still learning how react-native-reanimated works. The useSharedValue hook runs outside the react lifecycle which is why it's usually tied to UI events to increase FPS. I'll test using that value locally and see if it works.
app/utils/pay-links.ts
Outdated
|
|
||
| // TODO: Return all of these values from the API? | ||
|
|
||
| export const getPosUrl = (network: INetwork, address: string): string => { |
There was a problem hiding this comment.
These methods will have to change to fit our new way of keeping track of different galoy instances. Instead of assuming there is only one regtest, testnet, and mainnet instance and then translating that to a galoy backend, we will have different galoy backend options (staging, local, bbw/prod) and ultimately ask the backend for the bitcoin network that it is on.
There was a problem hiding this comment.
Yeah agreed - but we don't currently have the backend setup to return all these things right? I would suggest we separate out that change in a different PR anyway since it's not related to this work.
There was a problem hiding this comment.
I tested locally and it didn't work using the shared value.
|
A couple feedback items for this page:
|
|
For the information modal, I think it would be good if we tried to stick to a consistent design throughout the app. Maybe we could try and extract a generic component from the DestinationInformation.tsx that is shown below or copy the layout/styling. |
|
A final development consideration is I think we should try and standardize our strategy for icons throughout the app. In some places we use the icons from react native elements https://reactnativeelements.com/docs/components/icon and in others we are using SVGs. I think it would probably be preferred to use the react native elements option as it has some default support for theming and is one less things to maintain vs managing svgs. I am open to other alternatives, although I think it would be good for us to establish a pattern around it. |
It would be great if we adopt an option where we can use the same icons for both mobile and web wallets. |
No description provided.