fix: use local i18n-js logic #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviroo
previously approved these changes
Aug 19, 2022
daviroo
force-pushed
the
translate-changes
branch
from
8f3499e to
315a1cc
Compare
daviroo
approved these changes
Aug 19, 2022
UncleSamtoshi
pushed a commit
that referenced
this pull request
Aug 19, 2022
* fix: use local i18n-js logic * chore: Fixed formatting Co-authored-by: Samer Buna <samerbuna@users.noreply.github.com> Co-authored-by: daviroo <david.borthwick@gmail.com>
daviroo
added a commit
that referenced
this pull request
Aug 31, 2022
* fix: use local i18n-js logic * chore: Fixed formatting Co-authored-by: Samer Buna <samerbuna@users.noreply.github.com> Co-authored-by: daviroo <david.borthwick@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@daviroo @UncleSamtoshi
We removed the i18n code from galoy-client (GaloyMoney/galoy-client#111) to be able to customize that code in the web wallet for Guatt.
This PR is needed for the mobile repo to work with the latest galoy-clientt.
Please test. I've only done minimal testing.