fix: Add global error handling. #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samerbuna
reviewed
Dec 21, 2021
| @@ -89,6 +90,7 @@ | |||
| "react-native-push-notification": "^8.1.1", | |||
| "react-native-qrcode-svg": "^6.0.6", | |||
| "react-native-reanimated": "^2.2.3", | |||
| "react-native-restart": "daviroo/react-native-restart.git#master", | |||
There was a problem hiding this comment.
Why do we need this fork?
There was a problem hiding this comment.
The released version of this wasn't working for me and there have been further changes on their master branch since. I tested their main branch and it works but jest was unable to resolve the module without the lib directory which is generated as part of the build (not stored on github). I branched the project and added the lib directory.
samerbuna
previously approved these changes
Dec 21, 2021
|
@daviroo please use rebase instead of merge |
daviroo
force-pushed
the
add-global-error-handling
branch
from
eeb0fec to
7bb33e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this PR can replace #363. It adds global error handling which will catch any fatal errors in the code and display an alert to the user instead of a white screen which was the previous behaviour. I've also added crashlytics reporting of the errors - it remains to be seen how useful this will be and we may want to use a different service for this in the future. I also added the ability for the user to restart the app and contact support in the dialogs. Tested in both ios and android in my local environment. Screenshots below. Ignore the dev debug screens behind the alerts - these won't show in production.
iOS
English
Spanish
@dolcalmi please check the translation
Android
English
Spanish
@dolcalmi please check the translation