feat: disable slide gesture around confirm slider button #3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prakhar-Agarwal-byte
force-pushed
the
disable-back-swipe
branch
2 times, most recently
from
c0fe9d7 to
82e3652
Compare
Signed-off-by: Prakhar Agarwal <prakharagarwal3031@gmail.com>
Prakhar-Agarwal-byte
force-pushed
the
disable-back-swipe
branch
from
82e3652 to
2582729
Compare
Signed-off-by: Prakhar Agarwal <prakharagarwal3031@gmail.com>
nicolasburtey
approved these changes
May 1, 2024
|
great PR thanks! |
| @@ -560,4 +567,7 @@ const useStyles = makeStyles(({ colors }) => ({ | |||
| justifyContent: "space-between", | |||
| alignItems: "center", | |||
| }, | |||
| sliderContainer: { | |||
| padding: 20, | |||
There was a problem hiding this comment.
should we make it even a bit bigger?
Suggested change
| padding: 20, | |
| padding: 32, |
There was a problem hiding this comment.
merging for now. we can change in a future PR later.
There was a problem hiding this comment.
Yes, this may help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3081
Added a
PanGestureHandlerwhich captures slide gestures in areas surrounding the confirm slider button. This prevents the native navigation handler from catching this event, and back action is not triggered.Demo:
XRecorder_01052024_155636.mp4