Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USD now builds with OpenVDB support #189

Merged
merged 1 commit into from
Jul 23, 2021
Merged

USD now builds with OpenVDB support #189

merged 1 commit into from
Jul 23, 2021

Conversation

proberts-cinesite
Copy link
Contributor

fixes #188

johnhaddon
johnhaddon requested changes Jul 23, 2021
View reviewed changes
Copy link
Member

@johnhaddon johnhaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Paul, LGTM. Could you rebase it for the 3_maintenance branch and add - USD : Enabled OpenVDB support to Changes.md please?

@johnhaddon
Copy link
Member

(When you make the MaterialX PR, that can go on master though - it's potentially a breaking change for people using their own MaterialX libs in Gaffer, so we'll hold that back until Gaffer 0.61)

@proberts-cinesite proberts-cinesite changed the base branch from master to 3_maintenance July 23, 2021 11:25
@johnhaddon johnhaddon merged commit 32d3ce0 into GafferHQ:3_maintenance Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnhaddon johnhaddon johnhaddon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure usdview supports VDB rendering
2 participants
@proberts-cinesite @johnhaddon