Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using BinarySensorDeviceClass #353

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Switch to using BinarySensorDeviceClass #353

merged 1 commit into from
Jan 31, 2024

Conversation

raman325
Copy link
Collaborator

Will hopefully stop the red herring comments in #349

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Will hopefully stop the red herring comments in #349
@firstof9 firstof9 added bugfix Fixes a bug breaking-change Changes that will require user intervention labels Jan 31, 2024
@firstof9
Copy link
Collaborator

Oh man the tests are old, but this change looks fine to me.

@firstof9 firstof9 merged commit f4f1046 into main Jan 31, 2024
2 of 8 checks passed
@raman325 raman325 deleted the raman325-patch-1 branch January 31, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes that will require user intervention bugfix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants