Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return nonsuccessful status code on failed build #539

Merged
merged 3 commits into from
Dec 30, 2021
Merged

return nonsuccessful status code on failed build #539

merged 3 commits into from
Dec 30, 2021

Conversation

sezna
Copy link
Contributor

@sezna sezna commented Dec 30, 2021

forc build would return success (0) even if the build failed. This PR updates it to return a failed status code.

@sezna sezna added bug Something isn't working forc labels Dec 30, 2021
@sezna sezna self-assigned this Dec 30, 2021
@sezna sezna mentioned this pull request Dec 30, 2021
Merged
adlerjohn
adlerjohn reviewed Dec 30, 2021
View reviewed changes
forc/src/ops/forc_fmt.rs Outdated Show resolved Hide resolved
@sezna sezna marked this pull request as draft December 30, 2021 19:37
adlerjohn
adlerjohn approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via CLI and seems fine.

@sezna sezna marked this pull request as ready for review December 30, 2021 20:49
@sezna sezna merged commit 2c4ae1e into master Dec 30, 2021
@sezna sezna deleted the sezna/return_nonsuccessful_status branch December 30, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

@leviathanbeak leviathanbeak Awaiting requested review from leviathanbeak

Assignees

@sezna sezna

Labels
bug Something isn't working forc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sezna @adlerjohn