Renaming color/token_id to asset_id #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlerjohn
approved these changes
Dec 22, 2021
|
Docs look fine, but the CI is failing. |
|
The JSON abi needs to be updated since it includes parameter names, I believe. |
sezna
previously approved these changes
Dec 23, 2021
|
Ah, approved before seeing the CI. I think this is because the test looks to see if the files are different, and you've used formatted JSON instead of the raw json abi output. We could fix this by either improving the test to use |
adlerjohn
approved these changes
Dec 23, 2021
sezna
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's more to be done on this front.
This PR tackles the user-facing usage of the terminology (Sway book),
lib-stdand the sway test-suite.It does not touch anything lower level than this.