Fix type unification between different sized integers. #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
sezna
approved these changes
Dec 14, 2021
adlerjohn
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't reporting downcasts as warnings because we had the order of 'received' and 'expected' types reversed.
Sometimes with unification it doesn't matter which types are which, but often there's definitely a 'received' and 'expected' type, and when there's a type error we report them as such. So most of this change is actually just renaming the args to
unify()fromaandbtoreceivedandexpected.But also, in particular I've changed the integer check and fixed the downcast warnings. We were assuming that the received type was the desired type but actually the expected type is where the casting should be made to.