Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't pass the depender's namespace into dependees #446

Merged
merged 1 commit into from
Dec 9, 2021
Merged

don't pass the depender's namespace into dependees #446

merged 1 commit into from
Dec 9, 2021

Conversation

sezna
Copy link
Contributor

@sezna sezna commented Dec 8, 2021

Massively improves performance as we aren't using exponentially more memory per dependency :)

@sezna sezna self-assigned this Dec 8, 2021
@adlerjohn adlerjohn added bug Something isn't working forc labels Dec 8, 2021
@canndrew
Copy link
Contributor

canndrew commented Dec 9, 2021

Thanks for this! That certainly makes my life easier.

@canndrew canndrew mentioned this pull request Dec 9, 2021
Merged
@sezna sezna merged commit 1f3cfb5 into master Dec 9, 2021
@sezna sezna deleted the sezna/fix_mem branch December 9, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

@leviathanbeak leviathanbeak Awaiting requested review from leviathanbeak

@nfurfaro nfurfaro Awaiting requested review from nfurfaro

Assignees

@sezna sezna

Labels
bug Something isn't working forc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sezna @canndrew @adlerjohn