feat: show broken tx #1063
Merged
feat: show broken tx #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 64.88% | 3250/5009 |
| 🔴 | Branches | 41.37% | 585/1414 |
| 🔴 | Functions | 48.33% | 678/1403 |
| 🟡 | Lines | 65.46% | 3134/4788 |
Test suite run success
236 tests passing in 72 suites.
Report generated by 🧪jest coverage report action from 661fd2b
|
one way to test this pr
|
matt-user
requested review from
luizstacio,
pedronauck and
LuizAsFight
as code owners
luizstacio
requested changes
Jan 26, 2024
There was a problem hiding this comment.
On transaction request
- When setting the gasLimit to a small value I got this error, it should show the the message as error but shows
Carefully check if all the details in your transaction are correct. Operations:. We should shot a text that only saysThe transaction fail with error: {error message }with unknown error we just sayThe transaction fail to run. - Also we could remove the icon to center better the error message.
- When the transaction was called from the SDK it should throw the error back to the DApp and close the popup instead of stay on the screen with the error.
On transaction history
- When opening a transaction on the history with panic or revert we can use the return error message from the SDK to show the message if it exists also.
luizstacio
approved these changes
Jan 30, 2024
luizstacio
pushed a commit
that referenced
this pull request
Jan 30, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. # Releases ## @fuel-wallet/connections@0.15.1 ### Patch Changes - Updated dependencies \[[`b81704c`](b81704c)]: - @fuel-wallet/types@0.15.1 - @fuel-wallet/sdk@0.15.1 ## @fuel-wallet/react@0.15.1 ### Patch Changes - [#1062](#1062) [`b81704c`](b81704c) Thanks [@arboleya](https://github.com/arboleya)! - chore: update fuels-ts to rc/salamander ## @fuel-wallet/sdk@0.15.1 ### Patch Changes - [#1062](#1062) [`b81704c`](b81704c) Thanks [@arboleya](https://github.com/arboleya)! - chore: update fuels-ts to rc/salamander - Updated dependencies \[[`b81704c`](b81704c)]: - @fuel-wallet/types@0.15.1 ## @fuel-wallet/playwright-utils@0.15.1 ### Patch Changes - [#1062](#1062) [`b81704c`](b81704c) Thanks [@arboleya](https://github.com/arboleya)! - chore: update fuels-ts to rc/salamander ## @fuel-wallet/types@0.15.1 ### Patch Changes - [#1062](#1062) [`b81704c`](b81704c) Thanks [@arboleya](https://github.com/arboleya)! - chore: update fuels-ts to rc/salamander ## fuels-wallet@0.15.1 ### Patch Changes - [#1062](#1062) [`b81704c`](b81704c) Thanks [@arboleya](https://github.com/arboleya)! - chore: update fuels-ts to rc/salamander - [#1063](#1063) [`bdfb2fa`](bdfb2fa) Thanks [@matt-user](https://github.com/matt-user)! - Add an error message for a failed simulated tx - Updated dependencies \[[`b81704c`](b81704c)]: - @fuel-wallet/types@0.15.1 - @fuel-wallet/sdk@0.15.1 - @fuel-wallet/connections@0.15.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes FE-78