Create TestCoin feat: add TestCoin helper class (#3445) #3460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks for the contribution! Before we can merge this, we need @crStiv to sign the Fuel Labs Contributor License Agreement. |
|
@crStiv is attempting to deploy a commit to the Fuel Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey @crStiv i think the file is missing an extension ( |
hey, I redid this, is it good? |
|
@Dhaiwat10 so what do you say |
TestCoin
Outdated
| @@ -0,0 +1,24 @@ | |||
| import { Coin } from '../types'; | |||
| import { randomBytes } from 'crypto'; | |||
There was a problem hiding this comment.
Suggested change
| import { randomBytes } from 'crypto'; | |
| import { randomBytes } from '@fuel-ts/crypto'; |
There was a problem hiding this comment.
- This is at the root of the project. Move to a more appropriate location like
packages/account/src/test-utils. - Add tests so we can validate the functionality.
- The
Coinshould reference the followingCointype.
Comment on lines
+10
to
+11
| id: params.id || `0x${randomBytes(32).toString('hex')}`, | ||
| owner: params.owner || `0x${randomBytes(32).toString('hex')}`, |
There was a problem hiding this comment.
Suggested change
| id: params.id || `0x${randomBytes(32).toString('hex')}`, | |
| owner: params.owner || `0x${randomBytes(32).toString('hex')}`, | |
| id: params.id || getRandomB256(), | |
| owner: params.owner || getRandomB256(), |
Favour helper functions
| return { | ||
| id: params.id || `0x${randomBytes(32).toString('hex')}`, | ||
| owner: params.owner || `0x${randomBytes(32).toString('hex')}`, | ||
| amount: params.amount || BigInt(1000000), |
There was a problem hiding this comment.
Suggested change
| amount: params.amount || BigInt(1000000), | |
| amount: params.amount || bn(1000000), |
Amount is a BN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
In this release, we:
TestCoinhelper class to simplify the creation of testCoinobjects for testing purposes.TestCoin.create: Generates a single test coin with customizable parameters.TestCoin.many: Generates an array of test coins based on shared parameters.Summary
This pull request introduces the
TestCoinhelper class, designed to streamline the creation of testCoinobjects. Thecreatemethod allows for the generation of a single coin with default or customized properties, while themanymethod supports bulk creation of coins. These utilities will improve the efficiency and readability of tests that rely onCoinobjects.Related Issues
TestCoinhelper class #3445Breaking Changes
None.
Checklist
Allow edits by maintainers.