Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: purge hardcoded snippets on 'using typegen' page #1403

Merged
merged 23 commits into from
Dec 14, 2023

Conversation

Dhaiwat10
Copy link
Member

Closes #1175

@Dhaiwat10 Dhaiwat10 added the docs Requests pertinent to documentation label Nov 3, 2023
@Dhaiwat10 Dhaiwat10 self-assigned this Nov 3, 2023
@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) November 3, 2023 22:15
@Dhaiwat10 Dhaiwat10 force-pushed the dp/hardcoded-snippets-typegen branch from 08c973d to 92cccc9 Compare November 3, 2023 22:18
arboleya

This comment was marked as resolved.

@Dhaiwat10 Dhaiwat10 requested a review from arboleya November 5, 2023 21:27
Copy link
Contributor

github-actions bot commented Nov 5, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 86.61% 6063/7000
🟡 Branches 70.7% 941/1331
🟡 Functions 77.35% 997/1289
🟢 Lines 86.59% 5806/6705

Test suite run success

1477 tests passing in 259 suites.

Report generated by 🧪jest coverage report action from 83c46a5

camsjams

This comment was marked as resolved.

Torres-ssf
Torres-ssf previously approved these changes Nov 7, 2023
Co-authored-by: Cameron Manavian <cameron.manavian@fuel.sh>
@Dhaiwat10 Dhaiwat10 dismissed stale reviews from Torres-ssf and camsjams via dec658a November 7, 2023 12:23
Dhaiwat10 and others added 2 commits November 7, 2023 17:53
Co-authored-by: Cameron Manavian <cameron.manavian@fuel.sh>
Torres-ssf
Torres-ssf previously approved these changes Dec 8, 2023
danielbate
danielbate previously approved these changes Dec 8, 2023
@arboleya arboleya added this to the Salamander milestone Dec 8, 2023
@Dhaiwat10 Dhaiwat10 changed the base branch from master to rc/salamander December 13, 2023 09:16
@Dhaiwat10 Dhaiwat10 closed this Dec 13, 2023
auto-merge was automatically disabled December 13, 2023 09:26

Pull request was closed

@Dhaiwat10 Dhaiwat10 reopened this Dec 13, 2023
@danielbate
Copy link
Member

danielbate commented Dec 13, 2023

FYI @Dhaiwat10 @Torres-ssf seems #1510 is impacting here also

@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) December 14, 2023 14:45
@Dhaiwat10 Dhaiwat10 merged commit 8bea836 into rc/salamander Dec 14, 2023
9 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/hardcoded-snippets-typegen branch December 14, 2023 14:55
@Dhaiwat10 Dhaiwat10 mentioned this pull request Dec 14, 2023
44 tasks
arboleya added a commit that referenced this pull request Jan 26, 2024
* chore: updating code owners (#1496)
* docs: purge hardcoded snippets on 'using typegen' page (#1403)
* chore: remove method that's same as base method (#1445)
* chore: implement RC workflow (#1497)
* Revert "feat: add `Predicate.getTransferTxId` helper (#1467)"
* chore: fix rc release string replace (#1529)
* docs: Update some hyperlinks to reference the new documentation hub (#1520)
* chore: improve rc release message (#1559)
* feat: GraphQL subscriptions (#1374)
* chore: pin `graphql-request` to `v5` (#1567)
* chore: upgrade `tsx` (#1574)
* feat: migrate from Jest to Vitest (#1310)
* chore: fix temp test workflow (#1579)
* chore: update required node engine in `create-fuels` (#1582)
* chore: add node version test matrix (#1575)
* chore: fix broken rc message (#1580)
* chore: update nodejs to v20 (#1544)
* feat: accepting addresses as `string` (#1583)
* chore: properly format the PR coverage report comment (#1586)
* fix: flaky test (#1590)
* docs: update `deposit-and-withdraw` page (#1591)
* feat: retry mechanism (#1474)
* feat: replaced `semver` dependency with custom implementation (#1594)
* feat: replace `elliptic` with `@noble/curves` (#1601)
* chore: fix CI failing due to missing tag in test (#1614)
* feat: improve ABI Coders `decode` validation (#1426)
* fix: do not generate a coverage diff without coverage artifact (#1629)
* chore: pinpoint vitest to 1.0.4 (#1637)
* chore: remove `ethers` dependency from `utils` (#1640)
* fix: `getOperation` for `Transfer Asset` (#1619)
* fix: remove external font dependencies (#1642)
* fix: generate RC PR comment on `pull_request` event only (#1648)
* fix: fix failing `rc` comment (#1657)
* chore: add missing test group (#1658)
* feat: implement browser compatibility testing (#1630)
* chore: fix string replace in `rc` ci (#1659)
* chore: adding extra reporters (#1661)
* chore: manually trigger `rc` CI (#1660)
* feat: use `submitAndAwait` graphql endpoint (#1615)
* fix: flaky retry test (#1654)
* feat: create a wallet without a provider (#1566)
* chore!: Share single chainConfig and review node-related utilities (#1602)
* chore: use new temporary coverage artifact (#1676)
* fix: internalizing `findBinPath` utility (#1679)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Requests pertinent to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace hardcoded snippets on the 'using typegen' docs page with proper snippets
7 participants