Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency for external fonts within the CI #1639

Closed
petertonysmith94 opened this issue Jan 12, 2024 · 2 comments
Closed

Remove dependency for external fonts within the CI #1639

petertonysmith94 opened this issue Jan 12, 2024 · 2 comments
Assignees
@petertonysmith94
Labels
chore Issue is a chore
Milestone
1 - Salamander

Comments

@petertonysmith94
Copy link
Contributor

Currently apps/demo-nextjs (maybe a few others) reaches out to an external provider to retrieve fonts (Google).
We should't rely on external services for our pipelines, so that we have a resilient process.

demo-nextjs:pretest: FetchError: request to https://fonts.googleapis.com/css2?family=Inter:wght@100..900&display=swap failed, reason: 
demo-nextjs:pretest: src/app/layout.tsx
demo-nextjs:pretest: `next/font` error:
demo-nextjs:pretest: Failed to fetch `Inter` from Google Fonts.
demo-nextjs:pretest:  ELIFECYCLE  Command failed with exit code 1.

[Source]
@danielbate danielbate added the chore Issue is a chore label Jan 12, 2024
@petertonysmith94
Copy link
Contributor Author

@danielbate pls assign

@arboleya
Copy link
Member

Read my mind.

@arboleya arboleya changed the title chore: Remove dependency for external fonts within the CI Remove dependency for external fonts within the CI Jan 12, 2024
@petertonysmith94 petertonysmith94 mentioned this issue Jan 13, 2024
Merged
@danielbate danielbate added this to the 1 - Salamander milestone Jan 15, 2024
@danielbate danielbate mentioned this issue Jan 15, 2024
Merged
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petertonysmith94 petertonysmith94

Labels
chore Issue is a chore
Projects
None yet
Milestone
1 - Salamander
Development

No branches or pull requests
3 participants
@arboleya @danielbate @petertonysmith94