-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade electron from 16 > 20 #2448
Upgrade electron from 16 > 20 #2448
Conversation
Just compiled from source and am using now. diff --git a/_scripts/build.js b/_scripts/build.js
index 14ce4fcd..63b8fffa 100644
--- a/_scripts/build.js
+++ b/_scripts/build.js
@@ -33,7 +33,7 @@ if (platform === 'darwin') {
arch = Arch.armv7l
}
- targets = Platform.LINUX.createTarget(['deb', 'zip', 'apk', 'rpm', 'AppImage', 'pacman'], arch)
+ targets = Platform.LINUX.createTarget(['pacman'], arch)
}
const config = {
@@ -97,7 +97,7 @@ const config = {
linux: {
category: 'Network',
icon: '_icons/icon.svg',
- target: ['deb', 'zip', 'apk', 'rpm', 'AppImage', 'pacman'],
+ target: ['pacman'],
},
// See the following issues for more information
// https://github.com/jordansissel/fpm/issues/1503 After that, you can: cd build
sudo pacman -U freetube*.pacman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't find any issues (Tested on Windows 11)
I think the main potential issue source would be linux... |
So far so good on my setup; Sway/wlroots.
It's just a Chromium browser with some node support. |
When u hover over the PIP window with your cursor VirtualBoxVM_Y3bR9hU60d.mp4Is this included in the breaking changes? I'm on Ubuntu everything works fine apart from this. Edit: I'm willing to make this sacrifice and approve this PR so other users can finally enjoy FT on Wayland instead of seeing black screen. |
I think it's a bug, have you tried 19.x version? |
19.x also got the same issue, but 18.x does not |
Wait for electron/electron#34406 to ve fixed before merging? |
Tested on Manjaro Linux and except for the already mentioned color problem (in #2448 (comment)), I could not find any issues yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed that the PR that fixes the issue got a label v21-x-y. The author of that OR is a member of the Electron team. So it likely wont be implemented in v20 therefore im willing to make the compromise and approve this so Wayland users can make use of FT again.
Edit: oops im just being dumb it also got the labels v19-x-y and v20-x-y. So im assuming it will get fixed in those versions.
new electron version released (20.0.3), not fixed yet (will hopefully be fixed for next electron version) |
FYI electron/electron#35034 has been merged we only need to wait for new version to be pushed out! |
I subscribe to released not PR merges... :P Wait should I also open a PR for electron 21...? |
21 will be released in 5 weeks So no u dont have to create a PR for 21 yet... Hopefully we can enjoy 20 for a little while. |
PIP fix included |
Also why @ChunkyProgrammer you just remove the label but not review 🤣 |
Pull Request Type
Please select what type of pull request this is:
Related issue
Might or might not fix issue in #2113
Closes #2358
Closes #2406
Closes #2359
Description
![image](https://user-images.githubusercontent.com/1018543/175764286-3e7f829b-6814-4bbf-88a0-8dd61774a9cf.png)
16.x is not supported anymore
From https://www.electronjs.org/blog/electron-17-0
Breaking change in 17.x =
desktopCapturer.getSources
Breaking change in 18.x =
nativeWindowOpen
Breaking change in 19.x
Breaking change in 20.x
Screenshots (if appropriate)
N/A
Testing (for code that is not small enough to be easily understandable)
Use test build daily in different OS
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.