Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PRIVILEGED_FUNCTION from function definition in xMessageBufferNextLengthBytes #989

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

kar-rahul-aws
Copy link
Member

Description

The PRIVILEGED_FUNCTION attribute should not be added during function definition, but during the function declaration.

Test Steps

MPU soak test for Message buffer on STM32H743ZI

Before applying the patch

Compilation fails with the error

Error[Pe065]: expected a ";" after __attribute__ in the definition for PRIVILEGED_FUNCTION

After applying the patch

Compilation is successful.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kar-rahul-aws kar-rahul-aws requested a review from a team as a code owner February 13, 2024 12:30
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8cfa715) 93.53% compared to head (2fabdea) 93.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #989   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files           6        6           
  Lines        3200     3200           
  Branches      889      889           
=======================================
  Hits         2993     2993           
  Misses         92       92           
  Partials      115      115           
Flag Coverage Δ
unittests 93.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kar-rahul-aws kar-rahul-aws merged commit 8c10944 into FreeRTOS:main Feb 13, 2024
18 checks passed
@kar-rahul-aws kar-rahul-aws deleted the fix_messagebuffer branch February 13, 2024 14:40
laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
* Update LPCXpresso55S69 SDK to 2.13.1

* Enable print from non-secure side

* Add register tests

Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants