Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comments related to portYIELD_FROM_ISR() #925

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

Skptak
Copy link
Member

@Skptak Skptak commented Dec 14, 2023

Description

Per request in a FreeRTOS-Forum Post modify existing comments related to portYIELD_FROM_ISR() in queue.h to be more consistent with what is said in other header file comment blocks. Also mention the function is port specific in tasks.c

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…more consistent with what is said in other header file comment blocks. Also mention the function is port specific in tasks.c
@Skptak Skptak requested a review from a team as a code owner December 14, 2023 17:23
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1384c68) 93.78% compared to head (d254149) 93.78%.

❗ Current head d254149 differs from pull request most recent head 26369d9. Consider uploading reports for the commit 26369d9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #925   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files           6        6           
  Lines        3186     3186           
  Branches      885      885           
=======================================
  Hits         2988     2988           
  Misses         91       91           
  Partials      107      107           
Flag Coverage Δ
unittests 93.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

11 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Skptak Skptak merged commit 553b0ad into FreeRTOS:main Dec 15, 2023
14 checks passed
@Skptak Skptak deleted the fixMissingportYIELD_FROM_ISRComment branch December 15, 2023 17:35
laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants