Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the sample smp configuration folder #922

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Remove the sample smp configuration folder #922

merged 2 commits into from
Dec 13, 2023

Conversation

chinglee-iot
Copy link
Member

@chinglee-iot chinglee-iot commented Dec 13, 2023 •
edited
Loading

Description

Remove the sample smp configuration folder. Define the following configurations in cmake instead

  • configNUMBER_OF_CORES = 2
  • configUSE_PASSIVE_IDLE_HOOK=0
if (DEFINED FREERTOS_SMP_EXAMPLE AND FREERTOS_SMP_EXAMPLE STREQUAL "1")
    message(STATUS "Build FreeRTOS SMP example")
    # Adding the following configurations to build SMP template port
    add_compile_options( -DconfigNUMBER_OF_CORES=2 -DconfigUSE_PASSIVE_IDLE_HOOK=0 )
endif()

Test Steps

The SMP template port build is included in CI action already.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chinglee-iot chinglee-iot requested a review from a team as a code owner December 13, 2023 07:00
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Dec 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd0f87c) 93.78% compared to head (5c03454) 93.78%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #922   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files           6        6           
  Lines        3186     3186           
  Branches      885      885           
=======================================
  Hits         2988     2988           
  Misses         91       91           
  Partials      107      107
Flag Coverage Δ
unittests 93.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kar-rahul-aws kar-rahul-aws merged commit e0bb21f into FreeRTOS:main Dec 13, 2023
16 checks passed
laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
@chinglee-iot
Cellular transport return socket closed when remote disconnected (Fre…
c040a8d 
…eRTOS#922)

* Update the return value if socket is closed by remote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kar-rahul-aws kar-rahul-aws kar-rahul-aws approved these changes

@aggarg aggarg aggarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chinglee-iot @aggarg @kar-rahul-aws