Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Portable/BCC formatting #828

Merged
merged 17 commits into from
Dec 7, 2023
Merged

Revert Portable/BCC formatting #828

merged 17 commits into from
Dec 7, 2023

Conversation

Skptak
Copy link
Member

@Skptak Skptak commented Oct 10, 2023 •
edited
Loading

Description

Revert the formatting on BCC ports

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Skptak Skptak requested a review from a team as a code owner October 10, 2023 23:12
@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bcf7bda) 93.78% compared to head (ba5514c) 93.78%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #828   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files           6        6           
  Lines        3184     3184           
  Branches      885      885           
=======================================
  Hits         2986     2986           
  Misses         91       91           
  Partials      107      107
Flag Coverage Δ
unittests 93.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Skptak Skptak mentioned this pull request Nov 8, 2023
Merged
2 tasks
chinglee-iot
chinglee-iot requested changes Nov 23, 2023
View reviewed changes
Copy link
Member

@chinglee-iot chinglee-iot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared with commit before #768
d6bccb1 | 2023-09-05 | Gaurav-Aggarwal-AWS | Fix heap address calculation issue (#781)

d6bccb1...Skptak:FreeRTOS-Kernel:fixBCCFormatting

portable/BCC/16BitDOS/PC/port.c : only revert ASM macro and ";" is missing.
portable/BCC/16BitDOS/common/port.c : only revert ASM macro

Suggest we revert the space as much as possible in these two files.

portable/BCC/16BitDOS/PC/port.c Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aggarg aggarg merged commit ac7fc39 into FreeRTOS:main Dec 7, 2023
17 checks passed
@Skptak Skptak deleted the fixBCCFormatting branch December 19, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinglee-iot chinglee-iot chinglee-iot approved these changes

@aggarg aggarg aggarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Skptak @aggarg @chinglee-iot @kar-rahul-aws