fix: add additional .ltorg directives to GCC CM3/CM4 mpu ports #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardBarry
approved these changes
Mar 10, 2022
aggarg
approved these changes
Mar 10, 2022
Codecov Report
@@ Coverage Diff @@
## main #473 +/- ##
=======================================
Coverage 92.44% 92.44%
=======================================
Files 4 4
Lines 1270 1270
Branches 343 343
=======================================
Hits 1174 1174
Misses 50 50
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When link-time-optimization is enabled, we ran into issues with offset-out-of-range errors. There has been a previous fix for this issue (#71), which seems to be insufficient for the MPU ports.
This PR adds the fix of the previous PR, i.e., the
.ltorgdirective, to the remaining places whereLDR Rd, =labelis used (a pseudo instruction which utilizes the literal pool) in the GCC/ARM_CM3_MPU and ARM_CM4_MPU ports.Test Steps
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.