update tasks.c #22
Merged
update tasks.c #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why don't get xNextTaskUnblockTime directly in this way?
Update tasks.c
|
Thanks for your suggestion - on first look it seems this could be a nice optimisation - we will test and report back. |
yuhui-zheng
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
The change itself looks good and has been tested on hw.
TCB_t *pxTCB at line 3951 is no longer needed in this local function. Let's merge this PR, and I will have a follow up PR to remove the local variable. (I cannot update this PR directly, looks like the source branch is deleted. )
jefftenney
pushed a commit
to jefftenney/FreeRTOS-Kernel
that referenced
this pull request
Mar 31, 2020
An optimization for prvResetNextTaskUnblockTime().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a more efficient way to update "xNextTaskUnblockTime" in prvResetNextTaskUnblockTime( ) ?