Fix compiler warning in config assert() on 64 bit architecture #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an assert, but caused warnings on 64-bit architectures because it compares a uint32_t with a 64-bit number. configASSERT( pxTCB->ulNotifiedValue[ uxIndexToNotify ] == ~0UL ); The changed to configASSERT( xTickCount == ( TickType_t ) 0 ); which has the same effect of forcing an assert, but without the warning.
configASSERT( pxTCB->ulNotifiedValue[ uxIndexToNotify ] == ~0UL ); with: configASSERT( xTickCount == ( TickType_t ) 0 ); Because the former generates a warning on 64-bit architectures.
cobusve
approved these changes
Sep 7, 2020
laroche
pushed a commit
to laroche/FreeRTOS-Kernel
that referenced
this pull request
Apr 18, 2024
* DNS.c commit * IP.c commit * Add various source & header files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code was used to force an assert but resulted in
compiler warnings on 64-bit architectures:
configASSERT( pxTCB->ulNotifiedValue[ uxIndexToNotify ] == ~0UL );
Hence it was replaced with the following, which also forces an assert,
but ensure the data types being compared are the same on all
architectures:
configASSERT( xTickCount == ( TickType_t ) 0 );