Remove access check from MPU wrapper for xTimerStartFromISR #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
aggarg
approved these changes
Aug 21, 2024
sirnish
approved these changes
Aug 21, 2024
shubnil
approved these changes
Aug 21, 2024
kar-rahul-aws
deleted the
update_mpu_wrapper_xTimerGenericCommandFromISR
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The function
xTimerStartFromISR()is called from an ISR. This call leads toMPU_xTimerGenericCommandFromISR()in mpu_wrappers_v2.c.In this latter function,pxHigherPriorityTaskWokenis checked for being writable byxPortIsAuthorizedToAccessBuffer()which is not needed as the code is executed from ISR and thus is privileged.Test Steps
Compiled and ran the CORTEX_MPU_M7_NUCLEO_H743ZI2_GCC_IAR_Keil Demo
Checklist:
Related Issue
#1126
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.