-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation warning about undelcared pthread_setname_np #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able to be resolved due to the definition of __USE_GNU (FreeRTOS#1077)
aggarg
reviewed
Jun 5, 2024
This reverts commit bcda6de.
…t being able to be resolved due to the definition of __USE_GNU (FreeRTOS#1077)" This reverts commit e31d0ba.
…able to be resolved due to the definition of __USE_GNU (FreeRTOS#1077)
Quality Gate passedIssues Measures |
aggarg
changed the title
Resolve the issue of low version glibc and gcc compilation not being …
Fix compilation warning about undelcared pthread_setname_np
Jun 10, 2024
aggarg
approved these changes
Jun 10, 2024
kar-rahul-aws
approved these changes
Jun 10, 2024
AhmedIsmail02
pushed a commit
to AhmedIsmail02/FreeRTOS-Kernel
that referenced
this pull request
Jun 12, 2024
…#1079) Use _GNU_SOURCE macro instead of __USE_GNU and define it before including portmacro.h. The reason is that portmacro.h includes limits.h which in-turn includes features.h - this results in __USE_GNU getting incorrectly undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
_GNU_SOURCE
macro instead of__USE_GNU
and define it before including portmacro.h. The reason is that portmacro.h includes limits.h which in-turn includes features.h - this results in__USE_GNU
getting incorrectly undefined.Test Steps
Checklist:
Related Issue
#1077
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.