Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More winpr fixes #8255

Merged
merged 2 commits into from
Sep 28, 2022
Merged

More winpr fixes #8255

merged 2 commits into from
Sep 28, 2022

Conversation

hardening
Copy link
Contributor

No description provided.

4a71cab broke wf_events.c.
The drive channel was not building because of missing definitions.
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/8009/

Copy link
Member

@mfleisz mfleisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfleisz mfleisz merged commit c5c2e37 into FreeRDP:master Sep 28, 2022
@@ -34,7 +34,7 @@

#include <freerdp/event.h>

#include <Windowsx.h>
#include <windowsx.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hardening ok, looks like mingw has different header (capitialization) than windows itself?

@hardening hardening deleted the more_winpr_fixes branch October 4, 2022 13:55
mihainradu pushed a commit to UiPath/FreeRDP that referenced this pull request Dec 7, 2022
* Fix build with mingw

4a71cab broke wf_events.c.
The drive channel was not building because of missing definitions.

* winpr: make functions return False when not implemented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants